Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backport-2.1: storage: delay manual splits that would result in more snapshots #33015

Merged
merged 1 commit into from Dec 11, 2018

Conversation

tbg
Copy link
Member

@tbg tbg commented Dec 11, 2018

Backports #32594. This didn't apply cleanly, but only because I never
cherry-picked #32594 and #32594 refers a variable introduced within.

Fixes #32898.
Fixes #32900.
Fixes #32895.

/cc @cockroachdb/release

Release note (bug fix): resolve a cluster degradation scenario that
could occur during IMPORT/RESTORE operations, manifested through a
high number of pending Raft snapshots.

@tbg tbg requested a review from a team December 11, 2018 15:05
@cockroach-teamcity
Copy link
Member

This change is Reviewable

…snapshots

Backports cockroachdb#32594. This didn't apply cleanly, but only because I never
cherry-picked cockroachdb#32594 and cockroachdb#32594 refers a variable introduced within.

Fixes cockroachdb#32898.
Fixes cockroachdb#32900.
Fixes cockroachdb#32895.

/cc @cockroachdb/release

Release note (bug fix): resolve a cluster degradation scenario that
could occur during IMPORT/RESTORE operations, manifested through a
high number of pending Raft snapshots.
Copy link
Collaborator

@petermattis petermattis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained

@tbg tbg merged commit 138369e into cockroachdb:release-2.1 Dec 11, 2018
@tbg tbg deleted the backport2.1-32594 branch December 11, 2018 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants